You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Gemfile.lock to relax dependancies between different Ruby versions.
note:Gemfile.lock is bundled with a specific version of bundler, not sure if there is a reason to keep the lock file as versions can locked from gemspec.
@berkos Hi Antonis!
Thanks for the PR – I like that you added the versions for Travis 👍 Much appreciated.
Regarding the Gemfile.lock – the lock is for developing the gem itself, to ensure that contributors have the same versions as I do when developing. The gemspec is for the gem's dependencies itself. They have different purposes. So if you could revert e701247, I'd be happy to pull this PR (or you could convince me, that would be fine also 😊)
Cheers and thanks again!
@berkos Hi Antonis!
Thanks for the PR – I like that you added the versions for Travis 👍 Much appreciated.
Regarding the Gemfile.lock – the lock is for developing the gem itself, to ensure that contributors have the same versions as I do when developing. The gemspec is for the gem's dependencies itself. They have different purposes. So if you could revert e701247, I'd be happy to pull this PR (or you could convince me, that would be fine also 😊)
Cheers and thanks again!
Hi @floere. Thanks very much for your reply!
Ruby 2.5.5 was failing as Bundler 1.16.6 was not available in that version.
Also of the reasons that I had the Gemfile.lock removed is because given it's a library you want to it to be available to work with a variety of clients(apps) at the moment the tests for an instance run with versions that are declared in the lock file. If someone would use the gem in his Gemfile would possible used latest version that the one used to be developed, gemspec would allow this, but the tests of the library would not have run against these versions.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋
Gemfile.lockto relax dependancies between different Ruby versions.note: Gemfile.lock is bundled with a specific version of bundler, not sure if there is a reason to keep the lock file as versions can locked from gemspec.
Thanks!